[RFR] rewrite RichTextInput to TypeScript #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThieryMichel
requested changes
Jan 3, 2020
|
@ThieryMichel done |
fzaninotto
requested changes
Jan 6, 2020
|
Thanks! I forgot to ask that you PR against the |
tlaziuk
force-pushed
the
rich-text-input-typescript
branch
from
847782c to
b4fa210
Compare
fzaninotto
requested changes
Jan 28, 2020
| @@ -123,20 +157,13 @@ const RichTextInput = ({ | |||
| ); | |||
| }; | |||
|
|
|||
| RichTextInput.propTypes = { | |||
There was a problem hiding this comment.
need to keep the propTypes. Compile-time type validation doesn't replace runtime type checking (unfortunately). Would you mind adding these back?
| ]), | ||
| fullWidth: PropTypes.bool, | ||
| configureQuill: PropTypes.func, | ||
| RichTextInput.defaultProps = { |
There was a problem hiding this comment.
Please keep these as default values for the props instead, React is deprecating defaultProps for function components (facebook/react#16210).
tlaziuk
force-pushed
the
rich-text-input-typescript
branch
from
b4fa210 to
5430e6e
Compare
tlaziuk
commented
Feb 3, 2020
| @@ -125,14 +160,6 @@ RichTextInput.propTypes = { | |||
| label: PropTypes.string, | |||
| options: PropTypes.object, | |||
| source: PropTypes.string, | |||
| toolbar: PropTypes.oneOfType([ | |||
There was a problem hiding this comment.
I removed that because Quill should validate it's options itself, IMO it's a good practice because leaving that breaks the composition.
fzaninotto
approved these changes
Feb 7, 2020
|
Thanks! |
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found that you need help with rewriting the project to TypeScript.
I'm not sure about removing the
prop-typesdependency, but the TypeScript is here so IMO it is not needed anymore, leave a comment if you have opposite opinion so I'll restore it.Instead of default values in object spread I've added
defaultProps, also - the full object of props is passed touseStyleshook.From minor things - I had to cast the styles (*Stylsheet file) object to
anybecause apparently the object is of invalid type (eg. numeric string is used instead of number) - but changing that may be considered as a breaking change because treating the values depends on used JSS engine.