[RFR] Update tutorial app creation command #4187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the tutorial, `create-react-app` is installed globally. Yet, it is no longer supported as shown with the following error message: > Please note that global installs of create-react-app are no longer supported. This PR uses `npx`, the way recommended by [create-react-app](https://github.com/facebook/create-react-app).
jpetitcolas
changed the title
djhi
reviewed
Dec 18, 2019
| @@ -12,8 +12,7 @@ This 30 minutes tutorial will expose how to create a new admin app based on an e | |||
| React-admin uses React. We'll use Facebook's [create-react-app](https://github.com/facebookincubator/create-react-app) to create an empty React app, and install the `react-admin` package: | |||
|
|
|||
| ```sh | |||
| npm install -g create-react-app | |||
| create-react-app test-admin | |||
| npx create-react-app test-admin | |||
There was a problem hiding this comment.
Suggested change
| npx create-react-app test-admin | |
| npx create-react-app test-admin | |
| # or | |
| yarn create react-app test-admin | |
| # or | |
| npm init react-app test-admin |
There was a problem hiding this comment.
There was a problem hiding this comment.
Didn't know about these extra commands. Thanks! That being said, I'm not sure we should be so exhaustive to keep it simple. But your choice! :)
There was a problem hiding this comment.
As a yarn user, I only knew about npx and yarn create. Just discovered npm had an init :)
|
Superseded by #4198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tutorial,
create-react-appis installed globally. Yet, it is no longer supported as shown with the following error message:This PR uses
npx, the way recommended by create-react-app.