Make pagination more extendable #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. This also closes #4008 |
djhi
requested changes
Dec 10, 2019
|
Done! |
fzaninotto
reviewed
Dec 10, 2019
| @@ -16,6 +16,8 @@ const Pagination = ({ | |||
| total, | |||
| setPage, | |||
| setPerPage, | |||
| ActionsComponent, | |||
There was a problem hiding this comment.
not sure about this name. I think in other places (or in material-ui), component props start with lowercase and don't include the term "component"
There was a problem hiding this comment.
You're right: list, create, show etc, are component (and not elements) yet their props are lowercase and without component at the end.
I submitted the change
fzaninotto
approved these changes
Dec 11, 2019
This was referenced Dec 11, 2019
fzaninotto
added a commit
that referenced
this pull request
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4131
Closes #4008