feat: create declaration file for react-admin package #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, and thanks for the PR. If we merge it, that'll break all the TypeScript projects depending on react-admin. The types weren't thoroughly tested and aren't ready for publication yet. We'll publish them when they're ready. |
|
Worth at least exporting them to |
|
And I'm happy to help to improve react-admin's typescript types! |
|
No, I don't think it's worth yet. Feel free to convert a few JS files to TS in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
react-adminpackage wasn't outputting declaration files. So I changed the config to output them.Changes
declarationtotrueinreact-admintypescriptand fix one issue that cropped up