Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <BulkExportButton> component #4109

Merged
merged 4 commits into from
Dec 9, 2019
Merged

Add <BulkExportButton> component #4109

merged 4 commits into from
Dec 9, 2019

Conversation

fzaninotto
Copy link
Member

  • Move export logic to ra-core
  • Use context instead of props to get exporter
  • Add <BulkExportButton> component
  • Use it in <PostList> in simple example
  • Add doc

Capture d’écran de 2019-12-03 16-11-59

@fzaninotto fzaninotto added the RFR Ready For Review label Dec 3, 2019
@fzaninotto fzaninotto added this to the 3.1.0 milestone Dec 3, 2019
{...sanitizeRestProps(rest)}
>
<Title title={title} defaultTitle={defaultTitle} />
<ExporterContext.Provider value={exporter}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep adding stuff to the List context (like filters, selected ids, etc), I wonder if we shouldn't use a ListContext instead... opinions?

@djhi djhi merged commit 2f9a703 into next Dec 9, 2019
@djhi djhi deleted the refactor-exporter-logic branch December 9, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants