Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused prop in <LoadingIndicator> #4085

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Fix unused prop in <LoadingIndicator> #4085

merged 1 commit into from
Nov 29, 2019

Conversation

kopax
Copy link
Contributor

@kopax kopax commented Nov 29, 2019

Please double-check as I may be doing a mistake.

I haven't been able to use isLoading, according to <CircularProgress /> documentation, the props.isLoading is not used by mui nor <LoadingComponent />

@kopax
Copy link
Contributor Author

kopax commented Nov 29, 2019 •
edited
Loading

While this PR is being checked, just a side notes questions:

  • I am upgrading @bootstrap-styled/ra-ui for 3.0.2 and I am trying to work in examples/demo while editing package/**. I have started the server with make run-demo but it seems after a while, change does not get refreshed and I need to stop the server and make build && make run-demo.

Any tought about this? Thanks

fzaninotto
fzaninotto approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, in 2.x we used the connect() HOC and we forgot to remove the prop. Nice catch!

@fzaninotto fzaninotto merged commit 40ec07c into marmelab:master Nov 29, 2019
@fzaninotto
Copy link
Member

Thanks! As for the demo, there is no hot reloading for the changes in the react-admin packages - only for the changes made in the demo source.

@fzaninotto fzaninotto added this to the 3.0.3 milestone Nov 29, 2019
@fzaninotto fzaninotto changed the title fix(LoadingIndicator): remove unused isLoading props (https://material-ui.com/api/circular-progress/) Fix unused prop in <LoadingIndicator> Nov 29, 2019
@kopax kopax deleted the loading-indicator branch November 30, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@kopax @fzaninotto