Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Allow to extend useEditController #4075

Merged
merged 1 commit into from
Dec 10, 2019
Merged

[RFR] Allow to extend useEditController #4075

merged 1 commit into from
Dec 10, 2019

Conversation

Kmaschta
Copy link
Contributor

@Kmaschta Kmaschta commented Nov 28, 2019

useCreateController accepts a onSuccess and a onFailure props, but useEditController don't
So, I made this PR to have the same behavior for both of them

@Kmaschta Kmaschta added the WIP Work In Progress label Nov 28, 2019
@fzaninotto
Copy link
Member

Cool. You should PR against next rather than master.

`useCreateController` accepts a onSuccess and a onFailure props, but `useEditController` don't
So, I made this PR to have the same behavior for both of them
@Kmaschta Kmaschta changed the base branch from master to next December 4, 2019 15:55
@Kmaschta Kmaschta added RFR Ready For Review and removed WIP Work In Progress labels Dec 4, 2019
@Kmaschta Kmaschta changed the title Allow to extend useEditController [RFR] Allow to extend useEditController Dec 4, 2019
@Kmaschta
Copy link
Contributor Author

Kmaschta commented Dec 4, 2019

Done 👍

@fzaninotto fzaninotto merged commit dd06be6 into next Dec 10, 2019
@fzaninotto fzaninotto deleted the extend-use-edit branch December 10, 2019 12:20
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.1.0 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants