[RFR] Add invite to create the first record when the list is empty #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very encouraging! |
m4theushw
force-pushed
the
empty-state
branch
2 times, most recently
from
e8f6fa6 to
0e63a83
Compare
m4theushw
changed the title
|
Could you PR against |
fzaninotto
requested changes
Dec 3, 2019
| @@ -28,6 +28,7 @@ Here are all the props accepted by the `<List>` component: | |||
| * [`filterDefaultValues`](#filter-default-values) (the default values for `alwaysOn` filters) | |||
| * [`pagination`](#pagination) | |||
| * [`aside`](#aside-component) | |||
| * [`emptyState`](#empty-state) | |||
| @@ -683,6 +685,34 @@ const Aside = ({ data, ids }) => ( | |||
| ``` | |||
| {% endraw %} | |||
|
|
|||
| ### Empty state | |||
|
|
|||
| When there is no result, and there is no active filter, and the resource has a create page then a special page inviting the user to create the first record is displayed. Use the `emptyState` prop to modify that page, passing your custom component: | |||
There was a problem hiding this comment.
Suggested change
| When there is no result, and there is no active filter, and the resource has a create page then a special page inviting the user to create the first record is displayed. Use the `emptyState` prop to modify that page, passing your custom component: | |
| When there is no result, and there is no active filter, and the resource has a create page, react-admin displays a special page inviting the user to create the first record. | |
| You can use the `emptyState` prop to replace that page by a custom component: |
| ``` | ||
| {% endraw %} | ||
|
|
||
| The `emptyState` component receives the same props as the `aside` prop. Read the [section above](#aside-component) to check them. |
There was a problem hiding this comment.
no, please repeat them - developers don't read the docs sequentially.
|
|
||
| const EmptyState = ({ basePath }) => ( | ||
| <div style={{ textAlign: 'center', margin: '1em' }}> | ||
| <h1>No products available</h1> |
There was a problem hiding this comment.
I'd use resource in the example
| const resourceName = translate(`resources.${resource}.name`, { | ||
| smart_count: 0, | ||
| _: inflection.humanize(resource), | ||
| }).toLowerCase(); |
There was a problem hiding this comment.
We don't use toLowerCase anywhere else on the naming, and I humanize should do the trick.
| > | ||
| <Title title={title} defaultTitle={defaultTitle} /> | ||
|
|
||
| const renderChildren = () => ( |
|
Why did you close your PR? |
|
@fzaninotto I will open another PR targeting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2639
<EmptyState />