Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console errors in tests #4050

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Fix console errors in tests #4050

merged 1 commit into from
Nov 26, 2019

Conversation

fzaninotto
Copy link
Member

I removed almost all errors in unit tests. I don't understand the last one, that we can leave for now.

image

@fzaninotto fzaninotto added the RFR Ready For Review label Nov 26, 2019
@fzaninotto fzaninotto added this to the 3.0.2 milestone Nov 26, 2019
@djhi
Copy link
Collaborator

djhi commented Nov 26, 2019

I removed almost all errors in unit tests. I don't understand the last one, that we can leave for now.

I think the last one occurs because the dataProvider used in TestContext does not return anything

@djhi djhi merged commit be27f96 into master Nov 26, 2019
@djhi djhi deleted the fix-test-warnings branch November 26, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants