Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix RadioButtonGroupInput label size #3974

Merged
merged 2 commits into from
Nov 14, 2019
Merged

[RFR] Fix RadioButtonGroupInput label size #3974

merged 2 commits into from
Nov 14, 2019

Conversation

fzaninotto
Copy link
Member

Before:

image

After:
image

Closes #3955

@fzaninotto fzaninotto added this to the 3.0.0 milestone Nov 12, 2019
@djhi
Copy link
Collaborator

djhi commented Nov 13, 2019

I think this is actually an issue in material-ui. It looks like the label should be in the focused state by default in the guidelines: https://material.io/components/selection-controls/#radio-buttons. We should probably open an issue on material-ui

@fzaninotto
Copy link
Member Author

Not sure, we do the same kind of tailor-made label positioning for the CheckboxGroupInput.

@djhi
Copy link
Collaborator

djhi commented Nov 14, 2019

Yes, and I feel the same about it

@djhi djhi merged commit 58a170a into next Nov 14, 2019
@djhi djhi deleted the Fix-radiobuttongroupinput-label-size branch November 14, 2019 08:09
@fzaninotto fzaninotto mentioned this pull request Nov 14, 2019
Closed
@natrim natrim mentioned this pull request Nov 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi