Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR][V3] TabbedFormTabs - validTabPaths fix index #3972

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[RFR][V3] TabbedFormTabs - validTabPaths fix index #3972

merged 1 commit into from
Nov 12, 2019

Conversation

natrim
Copy link
Contributor

@natrim natrim commented Nov 12, 2019

validTabPaths needs to contain all valid elements indexed by existence
else conditional tabs leave space and are not considered valid for active tab

problem was that Children.toArray(children) strips them before map so the indexes are different from the rendering Children.map

Nov-12-2019 10-04-11

repo: https://codesandbox.io/s/simple-i0xmz

  1. edit post
  2. try clicking tabs
  3. you will see the index starting at 2
  4. and comments not working right

validTabPaths needs to contain all valid elements indexed by existence
else conditional tabs leave space and are not considered valid for active tab
@natrim natrim changed the title TabbedFormTabs - validTabPaths fix index [RFR][V3] TabbedFormTabs - validTabPaths fix index Nov 12, 2019
@fzaninotto fzaninotto merged commit a1d6e74 into marmelab:next Nov 12, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.0.0 milestone Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants