Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR][v3] useSuggestions - don't crash on empty value #3971

Merged
merged 2 commits into from
Nov 13, 2019
Merged

[RFR][v3] useSuggestions - don't crash on empty value #3971

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5806e8c
useSuggestions - don't crash on empty value
natrim Nov 12, 2019
f34364c
useSuggestions - add falsy value test
natrim Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/ra-core/src/form/useSuggestions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ const useSuggestions = ({

export default useSuggestions;

const escapeRegExp = value => value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); // $& means the whole matched string
const escapeRegExp = value =>
value ? value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&') : ''; // $& means the whole matched string
natrim marked this conversation as resolved.
Show resolved Hide resolved

interface Options extends UseChoicesOptions {
choices: any[];
Expand Down