Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResettableTextField component endAdornment prop not being applied. #3905

Closed
wants to merge 8 commits into from
Closed

Fix ResettableTextField component endAdornment prop not being applied. #3905

wants to merge 8 commits into from

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Oct 30, 2019

Closes #3869

@WiXSL WiXSL force-pushed the patch-resettable-searchinput branch from a35a6c3 to 3cd39f2 Compare October 30, 2019 03:55
@djhi
Copy link
Collaborator

djhi commented Oct 30, 2019

Can you rebase ?

@djhi djhi added this to the 3.0.0 milestone Oct 30, 2019
@WiXSL WiXSL force-pushed the patch-resettable-searchinput branch from 3cd39f2 to 37c550a Compare October 30, 2019 12:13
@WiXSL
Copy link
Contributor Author

WiXSL commented Oct 30, 2019 •
edited
Loading

I don't like the fact that the clear value button changes the size of the Input in a SearchInput with resettable={true}.
I have no idea how to address that.

@fzaninotto
Copy link
Member

I found a more elegant solution: The clear button replaces the endAdornment when a ResettabletTaxtField is not empty.

@fzaninotto
Copy link
Member

But now the tests fail... Can you take a look?

@WiXSL
Copy link
Contributor Author

WiXSL commented Nov 1, 2019

I got it working!

@WiXSL WiXSL force-pushed the patch-resettable-searchinput branch from c25a4c7 to d14e396 Compare November 8, 2019 13:47
@WiXSL WiXSL requested a review from fzaninotto November 8, 2019 16:53
@fzaninotto fzaninotto removed this from the 3.0.0 milestone Nov 20, 2019
@WiXSL WiXSL force-pushed the patch-resettable-searchinput branch from fa44886 to 51737d8 Compare November 21, 2019 14:22
@WiXSL WiXSL requested a review from fzaninotto November 21, 2019 15:10
@WiXSL
Copy link
Contributor Author

WiXSL commented Nov 23, 2019 

<SearchInput source="q" alwaysOn resettable />

resettable

<SearchInput source="q" alwaysOn resettable clearAlwaysVisible />

resettable-clearAlwaysVisible

<SearchInput source="q" alwaysOn />

no-resettable

@WiXSL
Copy link
Contributor Author

WiXSL commented Nov 26, 2019

@fzaninotto, do you think this is ok?

fzaninotto added a commit that referenced this pull request Dec 3, 2019
@fzaninotto
Fix TextInput endAdornment when resettable
17a8dc9 
Closes #4069 and #3869.

Supersedes #3905
@fzaninotto fzaninotto mentioned this pull request Dec 3, 2019
Merged
@fzaninotto
Copy link
Member

The endAdornment code needed even more work to acomodate another bug (#4069), so I had to redo the patch it in #4107, which supersedes this PR. Thanks for your work anyway.

@fzaninotto fzaninotto closed this Dec 3, 2019
@WiXSL WiXSL deleted the patch-resettable-searchinput branch January 15, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto Awaiting requested review from fzaninotto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WiXSL @djhi @fzaninotto