Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete defaults to margin="dense" prop #3890

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Autocomplete defaults to margin="dense" prop #3890

merged 2 commits into from
Oct 29, 2019

Conversation

tdeo
Copy link
Contributor

@tdeo tdeo commented Oct 28, 2019

For consistency with other inputs

Should it also default to not being fullWidth ? Or even leverage ResttableTextInput to have the same visual aspect ?

Here's a codesandbox showing both side by side: https://codesandbox.io/s/practical-chandrasekhar-869ep
image

@tdeo
Autocomplete defaults to margin="dense" prop
edd5547 
For consistency with other inputs
@djhi
Copy link
Collaborator

djhi commented Oct 28, 2019

Should it also default to not being fullWidth ? Or even leverage ResttableTextInput to have the same visual aspect ?

Yes & yes!

Thanks :)

@djhi djhi added this to the 3.0.0 milestone Oct 28, 2019
@tdeo
Copy link
Contributor Author

tdeo commented Oct 29, 2019

I've actually never worked with Typescript before, and it turns out to be not that straightforward, can anyone pick this up ?

@fzaninotto fzaninotto merged commit 94171fc into marmelab:next Oct 29, 2019
@fzaninotto
Copy link
Member

Thanks!

@tdeo tdeo deleted the patch-3 branch October 29, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tdeo @djhi @fzaninotto