Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix DeleteWithConfirm throws exception #3889

Merged
merged 1 commit into from
Oct 29, 2019
Merged

[RFR] Fix DeleteWithConfirm throws exception #3889

merged 1 commit into from
Oct 29, 2019

Conversation

fzaninotto
Copy link
Member

closes #3873

@fzaninotto fzaninotto added this to the 3.0.0 milestone Oct 28, 2019
fzaninotto
fzaninotto commented Oct 28, 2019
View reviewed changes
packages/ra-ui-materialui/src/button/DeleteWithConfirmButton.js
@@ -98,16 +98,12 @@ const DeleteWithConfirmButton = ({
e.stopPropagation();
};

const handleDelete = useCallback(
event => {
event.stopPropagation();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event propagation is already stopped in Confirm

@djhi djhi merged commit 718ae8c into next Oct 29, 2019
@djhi djhi deleted the fix-delete-with-confirm branch October 29, 2019 08:15
@fzaninotto fzaninotto mentioned this pull request Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi