Unified imports of routing components to react-router-dom #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 16, 2019 09:49
…ted direct from react-router
fzaninotto
approved these changes
Oct 17, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3821, the import of routing components
Not: This is a partial fix to #3821 in that it encourages users to import the
react-router-domlibrary correctly (making occurrence of the issue less likely).This PR does not address the other part of a fix, in which
react-router-domneeds to be a peer dependency.There's one difficulty here.
react-router'sStaticContextis used in the typing system, but it's not part of the public API, and therefore not re-exported fromreact-router-dom. So I've had to leave that as being fromreact-router, and hope that doesn't defy the point of all this.