Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom icons for Confirm action buttons. #3812

Merged
merged 3 commits into from
Nov 21, 2019
Merged

Add custom icons for Confirm action buttons. #3812

merged 3 commits into from
Nov 21, 2019

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Oct 12, 2019 •
edited
Loading

This has been discussed and apparently abandoned at #3471

fzaninotto
fzaninotto requested changes Oct 14, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the new feature in JSDoc and in the documentation

@WiXSL
Copy link
Contributor Author

WiXSL commented Oct 14, 2019

I've updated the docs.
Let me know.

@WiXSL WiXSL requested a review from fzaninotto October 14, 2019 16:26
fzaninotto
fzaninotto reviewed Oct 15, 2019
View reviewed changes
docs/List.md Outdated Show resolved Hide resolved
@fzaninotto fzaninotto added this to the 3.1.0 milestone Oct 15, 2019
@WiXSL @fzaninotto
Update docs/List.md
8ab7afb 
Co-Authored-By: Francois Zaninotto <[email protected]>
@WiXSL WiXSL requested a review from fzaninotto October 16, 2019 20:06
@fzaninotto fzaninotto merged commit 91e02f9 into marmelab:next Nov 21, 2019
@fzaninotto
Copy link
Member

Thanks!

@WiXSL WiXSL deleted the patch-custom-confirm-icons branch November 21, 2019 14:55
@fzaninotto fzaninotto mentioned this pull request Jan 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@WiXSL @fzaninotto