-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds props to allow customizing the title and content of Confirm modals for delete buttons. #3760
Conversation
I'd prefer that the main component accept a |
Well, as far as I can tell, the message for all delete confirmations can be changed via translation, but it can't be customized for each different record type. Please correct me if I'm mistaken. How do you see the mechanics working with a |
You're right, most of the props currently passed to For BulkDeleteWithConfirm, the default I'll schedule your change for 3.1. |
Fabulous! Yes I will make that tweak. |
I adjusted the defaults for the bulk delete and also added PropTypes for the new props which I had forgotten to do in the initial changeset. Thanks for being so responsive and for maintaining a really useful framework! |
One last question: do you have a rough guess as to when you think 3.1 will be released? |
We give a rough estimate of the release dates in the milestones page. V3.1 will be published in November. |
Thanks! |
Adds props for customizing Confirm messages for delete actions.