[RFR] Fix Forms Remove Empty Values #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
approved these changes
Oct 2, 2019
This was referenced Oct 2, 2019
pemoreau
reviewed
Oct 2, 2019
Comment on lines
+18
to
+23
| if (typeof values[key] === 'object' && values[key] !== null) { | ||
| acc[key] = sanitizeEmptyValues(initialValues[key], values[key]); | ||
| } else { | ||
| acc[key] = | ||
| typeof values[key] === 'undefined' ? '' : values[key]; | ||
| } |
There was a problem hiding this comment.
As far as I understand you consider 3 cases:
- values[key] is undefined, in that case you initialize the value with ""
- values[key] is a non-null object, and you recursively sanitarize the values
- in all other cases, the value is kept as it is
I think you should also test that initialValues[key]!==null otherwise a recursive call may occurs and throw an error (Object.keys(null) is not defined)
Furthermore, if value[key]===nulll you keep the null value, is that the wanted behavior ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3656
Fixes #3551, #3660