Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Discriminated union type for auth action #3742

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

pemoreau
Copy link
Contributor

Applied discriminated union type for auth actions to make the code more uniform

@pemoreau pemoreau added this to the 3.0.0 milestone Sep 27, 2019
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure we export the type from auth ?

Users should be able to import them from ra-core

@pemoreau
Copy link
Contributor Author

Thanks.
I think this is the case:

  • AuthActionType is exported by src/auth/types.ts
  • src/auth/index.ts contains export * from './types';
  • src/index.ts contains export * from './auth';
    but correct me if I do not see something

@pemoreau pemoreau removed the v3-alpha label Sep 30, 2019
@djhi djhi merged commit bd78647 into next Sep 30, 2019
@djhi djhi deleted the discriminated-union-type-for-auth-action branch September 30, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants