Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Convert DataProvider to Object #3726

Merged
merged 30 commits into from
Sep 30, 2019
Merged

[RFR] Convert DataProvider to Object #3726

merged 30 commits into from
Sep 30, 2019

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Sep 23, 2019 •
edited by fzaninotto
Loading

Related to #3686

  • Add TypeScript type for DataProvider methods
  • Make useDataProvider return a proxied dataProvider
  • Remove handling of event in useMutation callback
  • Add converter for legacy (function) style dataProviders to make the change BC
  • Update examples
  • Update documentation
    • DataProvider
    • Querying the API
    • Other chapters
  • Update core data providers
    • ra-data-fakerest
    • ra-data-simple-rest
    • ra-data-json-server
    • ra-data-graphql-simple (too much work, the object/function wrapper is enough)
    • ra-data-graphcool (too much work, the object/function wrapper is enough)

@djhi djhi added this to the 3.0.0 milestone Sep 23, 2019
@djhi djhi force-pushed the data-provider-object branch from 65a17ca to bcfbf8d Compare September 24, 2019 14:55
djhi
djhi commented Sep 27, 2019
View reviewed changes
docs/DataProviders.md Outdated Show resolved Hide resolved
docs/DataProviders.md Outdated Show resolved Hide resolved
@fzaninotto fzaninotto changed the title [WIP] Convert DataProvider to Object [RFR] Convert DataProvider to Object Sep 29, 2019
@fzaninotto
Copy link
Member

Switching to RFR

@djhi
Copy link
Collaborator Author

djhi commented Sep 30, 2019

Sorry, need a rebase

djhi and others added 23 commits September 30, 2019 08:58
@djhi @fzaninotto
Introduce new DataProvider
e7e29b5
@djhi @fzaninotto
Update hooks
acbf414
@djhi @fzaninotto
Fix build
8200214
@djhi @fzaninotto
Fix tests
1bf05ab
@fzaninotto
Updates to jsDoc and signatures
cc7bca9
@fzaninotto
Make useMutation accept both defintition and call time params
a005e86
@fzaninotto
Fix failing test
2522d84
@fzaninotto
Make the change backwards compatible for withDataProvider users
2525498
@fzaninotto
fix type
e4e2004
@fzaninotto
fix usequeryWithstore when used with new verbs
deab63e
@fzaninotto
Migrate custom queries of demo app
e457cef
@fzaninotto
Fix createController
5b49a76
@fzaninotto
Fix unit test
17765c6
@fzaninotto
Fix linter warnings
4489996
@fzaninotto
convert ra-data-fakerest provider to object
40bded8
@fzaninotto
Remove generics in dataProvider types because TypeScript is dump
0d9f7c2
@fzaninotto
Migrate simple rest data provider to object
9cd3f10
@fzaninotto
rewrite DataProvider documentation
6a076ad
@fzaninotto
Allow to customize action in specialized query hooks
8227e47
@fzaninotto
fix useGetList hook updates list view by default
08c877c
@fzaninotto
Update Actions documentation
6301eb8
@fzaninotto
data provider hooks should not define the action
2ac7dc8
@fzaninotto
Review
84bb1c1
@fzaninotto fzaninotto mentioned this pull request Sep 30, 2019
Closed
40 tasks
pemoreau
pemoreau reviewed Sep 30, 2019
View reviewed changes
docs/CreateEdit.md Outdated Show resolved Hide resolved
examples/demo/src/orders/Basket.js Outdated Show resolved Hide resolved
packages/ra-core/src/controller/useListController.ts Outdated Show resolved Hide resolved
packages/ra-core/src/dataProvider/useMutation.ts Show resolved Hide resolved
packages/ra-core/src/dataProvider/useMutation.ts Show resolved Hide resolved
packages/ra-core/src/dataFetchActions.ts Show resolved Hide resolved
@djhi djhi merged commit fea71c8 into next Sep 30, 2019
@djhi djhi deleted the data-provider-object branch September 30, 2019 10:46
@rayman1104 rayman1104 mentioned this pull request Apr 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pemoreau pemoreau pemoreau left review comments

@fzaninotto fzaninotto fzaninotto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djhi @fzaninotto @pemoreau