Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GraphQL Interface type #3692

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Support for GraphQL Interface type #3692

merged 1 commit into from
Sep 16, 2019

Conversation

MichielDeMey
Copy link
Contributor

@MichielDeMey MichielDeMey commented Sep 15, 2019

This PR simply adds support for Interface types.

For example if you have a similar GraphQL schema

interface Device {
  ...    
}

type MotionSensor implements Device {
  ...    
}

type TemperatureSensor implements Device {
  ...
}

Device will then be picked up as a resource.

@fzaninotto
Copy link
Member

If I understand correctly, this is also a bugfix as the current graphQL provider fails when using interfaces?

@MichielDeMey
Copy link
Contributor Author

I would assume so. Haven't been able to test this with GraphCool or any other GraphQL services as I'm using a regular Apollo GraphQL server.

@djhi djhi merged commit ab9a31a into marmelab:master Sep 16, 2019
@djhi djhi added this to the 2.9.7 milestone Sep 16, 2019
@djhi
Copy link
Collaborator

djhi commented Sep 16, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants