Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR][v3][BC break] SimpleFormIterator - use resource fields label #3671

Merged
merged 1 commit into from
Sep 17, 2019
Merged

[RFR][v3][BC break] SimpleFormIterator - use resource fields label #3671

merged 1 commit into from
Sep 17, 2019

Conversation

natrim
Copy link
Contributor

@natrim natrim commented Sep 11, 2019

aka. use same format as FieldTitle to get translated labels in SImpleFormIterator from source without the need to write label's manually

@fzaninotto
Copy link
Member

I'm not sure I understand. Can you give a use case with sample code?

@natrim
Copy link
Contributor Author

natrim commented Sep 12, 2019

https://codesandbox.io/s/simple-79rgs

when you look to edit post, then go to miscelanous and add backlink, you will see that the fields in the iterator are not translated

Sep-12-2019 07-58-15

@fzaninotto fzaninotto merged commit 91c9094 into marmelab:next Sep 17, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.0.0 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants