-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR][v3] FormDataConsumer - add subscription prop to the FormDataConsumer #3670
Conversation
Did you notice any performance issues ? Did you measure this change actually improve performances ? |
i have big form (80 inputs, iterators, arrayinputs with tables) and get small lags spikes without this if writing to some input fast enough, so the speed up is only ~50ms, so most users will not notice any change btw. to fully remove the lags i debounced the render of FormDataConsumer with HoC |
I think FormDataConsumer should be "works all the time" component for subscribing to the form. For more fined grained subscriptions, I think users should use |
maybe i could add subscription prop to the FormDataConsumer |
Good idea! |
@fzaninotto changed it |
to pass to the final-form useFormState
Thanks! |
by default subscribe's to all changes like it is now
but user could change it by passing the subscription prop