[RFR] New AutocompleteArrayInput #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
changed the title
fzaninotto
requested changes
Sep 11, 2019
packages/ra-ui-materialui/src/input/AutocompleteArrayInput.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/AutocompleteArrayInput.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/AutocompleteArrayInput.spec.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Francois Zaninotto <[email protected]>
Co-Authored-By: Francois Zaninotto <[email protected]>
|
Reviewed. Note that I will probably refactor those components a lot along with the others which handle multiple choices in a future PR |
fzaninotto
approved these changes
Sep 12, 2019
This was referenced Sep 13, 2019
|
I should write this issue maybe in sandbox, but like is the same problem here reporterted, only i go to mencion it. i am testing the beta 3.0.0 version, and i am seeing that the problem with this component when working with ReferenceInput persist. Attached an image. In the firs image i typed the letter ka. In the second image i wrote the letters ka an the letter u. When the component filter, the filter value stay on top of the window. I hope to be clear and to be in the right place. Sure, thaks you a lot for all this work in this project, is great.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutocompleteArrayInputusingdownshiftAutocompleteInput- [ ] Refactor (hooks, etc.) to avoid too much code duplication betweenTo be done in another PRAutocompleteArrayInputandAutocompleteInput