Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redux-devtools-extension trace feature in development mode if available. #3661

Closed
wants to merge 17 commits into from
Closed

Add redux-devtools-extension trace feature in development mode if available. #3661

wants to merge 17 commits into from

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Sep 9, 2019 •
edited by Kmaschta
Loading

Closes #3658

@WiXSL WiXSL mentioned this pull request Sep 9, 2019
Closed
@fzaninotto
Copy link
Member

Why not enable it by default? I don't think adding a new prop to Admin makes much sense for that feature.

@WiXSL
Copy link
Contributor Author

WiXSL commented Sep 12, 2019 •
edited
Loading

Because in the site says the following:

"By default it's disabled as, depending of the use case, generating and serializing stack traces for every action can impact the performance."

Trace Feature

Maybe I could enable it in development mode only avoiding the Admin prop.

@WiXSL WiXSL changed the title Added devToolsTrace prop to Admin allowing Redux DevTools Trace to be enable. Add DevTools trace feature in development mode if available. Sep 12, 2019
@WiXSL WiXSL changed the title Add DevTools trace feature in development mode if available. Add redux-devtools-extension trace feature in development mode if available. Sep 12, 2019
@WiXSL WiXSL closed this Oct 6, 2019
@WiXSL WiXSL mentioned this pull request Oct 6, 2019
Merged
fzaninotto pushed a commit that referenced this pull request Oct 8, 2019
@WiXSL @fzaninotto
Add redux-devtools-extension trace feature in development mode if ava…
d03447c 
…ilable. (#3781)

* Added devToolsTrace prop to CoreAdmin

* Added devToolsTrace prop to allow Redux DevTools Trace to be enable.

* Changes suggested by Prettier

* Changes suggested by Prettier

* More Prettier suggestions.

* Removed trailing space.

* Revert #3661

* Add DevTools trace feature in development  mode if available.

* Corrected parentheses

* Prettier suggestions

* Prettier suggestion.

* Update CustomApp.md

* Update CustomApp.md

* Update CustomApp.md

* Update CustomApp.md

* Updated CustomApp.md to reflect DevToolsTrace usage

* Corrections to the docs.

* Requested changes to the docs.

* Added missing validation to the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WiXSL @fzaninotto