Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR][v3] SimpleFormIterator - don't display error if its object #3651

Merged
merged 1 commit into from
Sep 11, 2019
Merged

[RFR][v3] SimpleFormIterator - don't display error if its object #3651

merged 1 commit into from
Sep 11, 2019

Conversation

natrim
Copy link
Contributor

@natrim natrim commented Sep 5, 2019 •
edited
Loading

object means it's error's for children so we can ignore it as children will display the errors by themself's

fixes error - passing object to react

@natrim
SimpleFormIterator - don't display error if its object
3343d25 
object means it's error's for children's so we can ignore it as children will display the errors by themself's
djhi
djhi approved these changes Sep 9, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@djhi djhi added this to the 3.0.0 milestone Sep 9, 2019
@fzaninotto fzaninotto merged commit 9b968bb into marmelab:next Sep 11, 2019
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@natrim @fzaninotto @djhi