Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasBulkActions to useMemo inputs #3621

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Add hasBulkActions to useMemo inputs #3621

merged 1 commit into from
Aug 30, 2019

Conversation

Evgeny81
Copy link
Contributor

If hasBulkActions prop changed dynamically, DataGrid renders Checkbox only in the DataGridHeader and doesn't render Checkbox in every row because useMemo ignores this prop change.

@Evgeny81
Add hasBulkActions to useMemo inputs
a6cc1aa 
If hasBulkActions prop changed dynamically, DataGrid renders Checkbox only in the DataGridHeader and doesn't render Checkbox in every row because useMemo ignores this prop change.
djhi
djhi approved these changes Aug 29, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@djhi djhi added this to the 3.0.0 milestone Aug 29, 2019
@fzaninotto fzaninotto merged commit 4ac8564 into marmelab:next Aug 30, 2019
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Evgeny81 @fzaninotto @djhi