[RFR] Convert PaginationActions to hooks #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent from recompose/pure
djhi
requested changes
Aug 26, 2019
| ); | ||
|
|
||
| export default enhance(PaginationActions); | ||
| export default PaginationActions; |
There was a problem hiding this comment.
You should wrap this component with React.memo (basically the same as pure)
djhi
requested changes
Aug 26, 2019
| ); | ||
|
|
||
| export default enhance(PaginationActions); | ||
| export default React.memo(PaginationActions, () => true); |
There was a problem hiding this comment.
You're preventing this component to rerender when its props change. Please don't override the isEqual function (that's what pure does).
natrim
reviewed
Sep 2, 2019
| import ChevronLeft from '@material-ui/icons/ChevronLeft'; | ||
| import ChevronRight from '@material-ui/icons/ChevronRight'; | ||
| import compose from 'recompose/compose'; | ||
| import { translate } from 'ra-core'; | ||
| import { useTranslate } from 'react-admin'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
PaginationActionsto hooks.This was mostly straightforward conversion done step-by-step (running
make test-unitat every step). One note though... I removed the HOCrecompose/purealong with the non-default export. Using the pure-wrapped component does not pass thePaginationActions.spec. Let me know if I got this wrong.