Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Improve form look and feel #3594

Merged
merged 31 commits into from
Aug 30, 2019
Merged

[RFR] Improve form look and feel #3594

merged 31 commits into from
Aug 30, 2019

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Aug 23, 2019

Material design no longer advocates the usage of fields denoted by a simple underline. Only the "filled" and "outline" variants are documented in the material design guide.

The major bump in react-admin v3 is the right occasion to reflect that change. But we should let an escape hatch for users who absolutely don't want filled inputs. That is possible with the material ui theme, and we should make it possible to override the variant at the form level.

Also, I want to make forms more compact, so we use a dense margin by default.

Before After
image image
  • Provide a default theme with less ugly filled variant than mui default light
  • Provide a default theme with less ugly filled variant than mui default dark
  • Allow users to override margin and variant at the form level
  • Make common inputs dense and filled by default
  • Make other inputs dense and filled by default
  • Update Form documentation to mention the new props
  • Add upgrade guide

@fzaninotto fzaninotto added this to the 3.0.0 milestone Aug 23, 2019
@fzaninotto fzaninotto changed the title [WIP] Improve form look and feel [RFR] Improve form look and feel Aug 28, 2019
@fzaninotto
Copy link
Member Author

Switching to RFR. The failling tests also fail on next.

docs/CreateEdit.md Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit b343689 into next Aug 30, 2019
@fzaninotto fzaninotto deleted the form-look-and-feel branch August 30, 2019 06:27
@fzaninotto
Copy link
Member Author

Thanks for searching and fixing that hard bug!

@fzaninotto fzaninotto mentioned this pull request Sep 13, 2019
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants