-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Improve form look and feel #3594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
form-look-and-feel
branch
from
August 28, 2019 14:02
be1cd23
to
cb00c72
Compare
fzaninotto
changed the title
[WIP] Improve form look and feel
[RFR] Improve form look and feel
Aug 28, 2019
Switching to RFR. The failling tests also fail on |
fzaninotto
force-pushed
the
form-look-and-feel
branch
from
August 28, 2019 14:50
f7365d4
to
3e69b81
Compare
djhi
approved these changes
Aug 28, 2019
Thanks for searching and fixing that hard bug! |
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Material design no longer advocates the usage of fields denoted by a simple underline. Only the "filled" and "outline" variants are documented in the material design guide.
The major bump in react-admin v3 is the right occasion to reflect that change. But we should let an escape hatch for users who absolutely don't want filled inputs. That is possible with the material ui theme, and we should make it possible to override the variant at the form level.
Also, I want to make forms more compact, so we use a
dense
margin by default.margin
andvariant
at the form level