Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Migrate SelectArrayInput to TypeScript #3592

Merged
merged 3 commits into from
Aug 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -784,4 +784,9 @@ const OrderEdit = (props) => (
</SimpleForm>
</Edit>
);
```
```

## helperText is handled the same way in all components

Some components (such as `<SelectArrayInput />`) accepted the `helperText` in their `meta` prop. They now receive it directly in their props.
Besides, all components now display their error or their helperText, but not both at the same time.
4 changes: 2 additions & 2 deletions packages/ra-ui-materialui/src/input/InputWithOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ type OptionTextFunction<ChoiceType = any> = (record: ChoiceType) => string;

export interface InputWithOptionsProps<ChoiceType = any> {
choices: ChoiceType[];
optionText:
optionText?:
| string
| OptionTextFunction<ChoiceType>
| ReactElement<{ record: ChoiceType }>;
optionValue: string;
optionValue?: string;
}
296 changes: 0 additions & 296 deletions packages/ra-ui-materialui/src/input/SelectArrayInput.js

This file was deleted.

Loading