Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Convert DragLayer component to useStyles #3591

Merged
merged 1 commit into from
Aug 26, 2019
Merged

[RFR] Convert DragLayer component to useStyles #3591

merged 1 commit into from
Aug 26, 2019

Conversation

jaytula
Copy link
Contributor

@jaytula jaytula commented Aug 23, 2019

Convert DragLayer component to useStyles #3453

djhi
djhi approved these changes Aug 23, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you tried those changes on the simple example ? You'll have to login as admin/password to see the tags

@djhi djhi added this to the 3.0.0 milestone Aug 23, 2019
@jaytula
Copy link
Contributor Author

jaytula commented Aug 23, 2019

I tried dragging the tags around and appears to be working. It's a little tricky to know whether it was dropped into or out of an item or re-ordered.

Also temporarily set a backgroundColor on the DragLayer component (clases.layer) and tested dragging to know that the layer was activated when dragged.

@djhi djhi merged commit 9581961 into marmelab:next Aug 26, 2019
@djhi
Copy link
Collaborator

djhi commented Aug 26, 2019

Thanks!

@jaytula jaytula deleted the usestyles-draglayer branch August 28, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jaytula @djhi