Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] use makeStyles in BulkActions #3495

Closed
wants to merge 3 commits into from
Closed

[RFR] use makeStyles in BulkActions #3495

wants to merge 3 commits into from

Conversation

Kunnu01
Copy link
Contributor

@Kunnu01 Kunnu01 commented Aug 7, 2019 •
edited by Kmaschta
Loading

Related to #3453

@Kunnu01 Kunnu01 changed the title use makeStyles in BulkActions [RFR] use makeStyles in BulkActions Aug 7, 2019
@Kmaschta Kmaschta added this to the 3.0.0 milestone Aug 8, 2019
djhi
djhi approved these changes Aug 9, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

djhi
djhi reviewed Aug 9, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, BulkActions was deprecated in v2, so we're going to remove it completely in v3... I'm sorry I should have commented on the PR where you asked to work on it

@djhi
Copy link
Collaborator

djhi commented Aug 13, 2019

By the way, a PR to remove BulkActions would be appreciated :)

@Kunnu01
Copy link
Contributor Author

Kunnu01 commented Aug 13, 2019

Okay, I'll work on it.

@Kmaschta
Copy link
Contributor

Superseeded by #3517

@Kmaschta Kmaschta closed this Aug 13, 2019
@fzaninotto fzaninotto removed this from the 3.0.0 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kunnu01 @djhi @Kmaschta @fzaninotto