Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emptyText prop to SelectInput #3444

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Add emptyText prop to SelectInput #3444

merged 2 commits into from
Aug 5, 2019

Conversation

tdeo
Copy link
Contributor

@tdeo tdeo commented Jul 23, 2019

To address #3392

djhi
djhi requested changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @fzaninotto will confirm but I think this should target the next branch as it adds a new feature

docs/Inputs.md Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/SelectInput.js Outdated Show resolved Hide resolved
@djhi
Copy link
Collaborator

djhi commented Jul 24, 2019

It seems prettier did not run on the modified files. Can you check ?

@djhi
Copy link
Collaborator

djhi commented Jul 24, 2019

ping @fzaninotto: master or next ?

@fzaninotto
Copy link
Member

Definitely next

@tdeo tdeo changed the base branch from master to next July 31, 2019 14:48
@tdeo
Copy link
Contributor Author

tdeo commented Aug 1, 2019

@fzaninotto @djhi It's properly rebased on next

@tdeo
Apply suggestions from code review
9dddb66 
Fix poor copy-pasting

Co-Authored-By: Gildas Garcia <[email protected]>
djhi
djhi approved these changes Aug 1, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@djhi djhi added this to the 3.0.0 milestone Aug 1, 2019
@djhi
Copy link
Collaborator

djhi commented Aug 5, 2019

Thanks!

@djhi djhi merged commit cabecb1 into marmelab:next Aug 5, 2019
@tdeo tdeo deleted the tdeo/SelectInputEmptyText branch August 5, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tdeo @djhi @fzaninotto