Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Use makeStyles hooks on examples demo #3328

Merged
merged 2 commits into from
Jun 16, 2019
Merged

Conversation

zyhou
Copy link
Contributor

@zyhou zyhou commented Jun 12, 2019

Use makeStyles on demo

Review with "Hide whitespace changes" options in Github

@zyhou zyhou force-pushed the use-hooks-on-demo branch from daec469 to 3446ea0 Compare June 12, 2019 14:55
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I think it makes the code easier to read. What's left for RFR?

withWidth(),
withStyles(styles)
);
const enhance = compose(withWidth());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for compose anymore here as there is only one HOC

@zyhou zyhou changed the title [WIP] Use makeStyles hooks on examples demo [RFR] Use makeStyles hooks on examples demo Jun 13, 2019
@zyhou
Copy link
Contributor Author

zyhou commented Jun 13, 2019

Now it's RFR, I didn't test all the pages on the demo

@fzaninotto fzaninotto merged commit 18a4a12 into next Jun 16, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto deleted the use-hooks-on-demo branch June 16, 2019 18:59
@fzaninotto fzaninotto added this to the 3.0.0 milestone Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants