[RFR] Replace tslint with eslint #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
djhi
commented
Jun 8, 2019
•
djhi
commented
- Replace tslint with eslint
- Adjust configuration
- Replace all tslint comments with eslint ones
djhi
commented
Jun 8, 2019
djhi
commented
Jun 8, 2019
fzaninotto
requested changes
Jun 8, 2019
| @@ -73,9 +73,6 @@ interface Props { | |||
| const ShowController = (props: Props) => { | |||
| useCheckMinimumRequiredProps('Show', ['basePath', 'resource'], props); | |||
| const { basePath, children, id, resource } = props; | |||
| if (!children) { | |||
djhi
changed the title
fzaninotto
requested changes
Jun 12, 2019
djhi
force-pushed
the
replace-tslint-with-eslint
branch
from
2d7cd13 to
fe2e31e
Compare
djhi
changed the title
fzaninotto
requested changes
Jun 13, 2019
| case DELETE: | ||
| return { | ||
| id: params.id, | ||
| }; | ||
| default: | ||
| console.log('Unknown fetch verb'); |
There was a problem hiding this comment.
No, unknown fetch verbs are allowed and can be implemented in custom dataProviders
There was a problem hiding this comment.
Those dataProviders did not handle them at all and returned undefined. How should we handle that ?
| case DELETE: | ||
| return { | ||
| id: preparedParams.id, | ||
| }; | ||
| default: | ||
| console.log('Unknown fetch verb'); |
There was a problem hiding this comment.
Same, we don't mind unknown fetch verbs
fzaninotto
approved these changes
Jun 13, 2019
djhi
force-pushed
the
replace-tslint-with-eslint
branch
from
708f445 to
bbaf62a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.