Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Factorize prettier logic to prettierrc #3258

Merged
merged 1 commit into from
May 21, 2019
Merged

[RFR] Factorize prettier logic to prettierrc #3258

merged 1 commit into from
May 21, 2019

Conversation

fargito
Copy link
Contributor

@fargito fargito commented May 21, 2019

Hello !

I noticed a duplication in the tslint and prettier configuration, so I factorized it in a prettierrc configuration file.

Thanks for your awesome project !

djhi
djhi approved these changes May 21, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much better indeed 👍

@fzaninotto fzaninotto merged commit fde0c3f into marmelab:master May 21, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 2.9.2 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.
3 participants
@fargito @fzaninotto @djhi