-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Migrate simple example to hooks #3225
Conversation
621d571
to
06d8d8c
Compare
9c8f2d7
to
4f2d985
Compare
@djhi Can you take a look on If you use |
464e020
to
9b130d0
Compare
@zyhou I fixed the useSelector bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed today, I think we shouldn't use useCallback
all the time but only if and when we notice performance issues. Not sure it is important though.
No, useCallback wasn't the cause of the problem. |
I didn't say it was. I just think they aren't necessary unless a performance issue arise. |
I really think we are over-complicating things with those |
Let's merge it like that. We'll review it once the core performance gets on par with 2.0. |
PostList.js
hooksPostCreate.js
hooksResetViewsButton.js
hooksCommentEdit.js
to hooksCommentList.js
to hooksPostPreview.js
to hooksPostQuickCreate.js
hooksPostQuickCreateCancelButton.js
to hooksPostReferenceInput.js
to hooksUserEdit.js
hooksuseSelector
isLoading
(don't remove the props)Review with "Hide whitespace changes" params