Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Extract custom hooks from controllers #3217

Merged
merged 4 commits into from
May 15, 2019
Merged

[RFR] Extract custom hooks from controllers #3217

merged 4 commits into from
May 15, 2019

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented May 13, 2019 •
edited
Loading

Extract useListParams hook

@djhi djhi requested a review from fzaninotto May 13, 2019 17:23
fzaninotto
fzaninotto requested changes May 13, 2019
View reviewed changes
packages/ra-core/src/controller/useList.ts Outdated Show resolved Hide resolved
packages/ra-core/src/controller/useList.ts Outdated Show resolved Hide resolved
@fzaninotto
Copy link
Member

Why didn't you move setFilter()?

@djhi
Copy link
Collaborator Author

djhi commented May 14, 2019

Why didn't you move setFilter()?

I was planning to extract a separate hook for filters but it may be too soon. I'll try to transform the controller into a single hook first

@djhi djhi requested a review from fzaninotto May 14, 2019 07:34
@djhi djhi changed the title [WIP] Extract custom hooks from controllers [RFR] Extract custom hooks from controllers May 15, 2019
@djhi djhi added this to the 3.0.0 milestone May 15, 2019
@fzaninotto fzaninotto merged commit 69b6ea2 into next May 15, 2019
@fzaninotto fzaninotto deleted the extract-hooks branch May 15, 2019 12:00
@fzaninotto fzaninotto mentioned this pull request May 15, 2019
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto