Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagrid rowClick="toggle" #3120

Closed
wants to merge 2 commits into from
Closed

Datagrid rowClick="toggle" #3120

wants to merge 2 commits into from

Conversation

possi
Copy link

@possi possi commented Apr 11, 2019 •
edited by djhi
Loading

Allow mass action selection with click on entire row.

@djhi djhi requested a review from fzaninotto April 11, 2019 12:59
djhi
djhi approved these changes Apr 11, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It may take some time before we merge this though. I'll wait for @fzaninotto approval

fzaninotto
fzaninotto requested changes Apr 16, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toggle is a bit vague IMO, I'd prefer toggleSelection.

You should document and test that new option, too.

@fzaninotto
Copy link
Member

Any updates?

@fargito fargito mentioned this pull request May 23, 2019
Merged
@fzaninotto
Copy link
Member

superseded by #3270

@fzaninotto fzaninotto closed this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto requested changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@possi @fzaninotto @djhi