Prepare ra-ui-materialui Migration to TypeScript #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I locally added the `checkJs` option to the package `tsconfig.json` file (not commited). This gives us the opportunity to fix many issues before starting the migration to TS. - [x] Use `createStyles` - [x] Check `isValidElement` before cloning where necessary - [x] Use `Children.only` before cloning when necessary - [ ] Find a TypeScript compatible way to sanitize props - [ ] Fix all other possible errors
|
124 errors left, from 235 when I started... 😩 Most remaining errors won't be fixed without actually migrating to TS. |
fzaninotto
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I locally added the
checkJsoption to the packagetsconfig.jsonfile (not commited). This gives us the opportunity to fix many issues before starting the migration to TS.createStylesisValidElementbefore cloning where necessaryChildren.onlybefore cloning when necessarymaterial-uito1.5.1(which we already use on many projects anyway)