Add an optional emptyValue to SelectInput #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmelab#2234 introduced a breaking change for our application. This change adds an optional custom empty value which is used when allowEmpty is set.
|
Thanks @edy for this PR! Is it ok to be merged for 2.7.1? |
|
sure |
djhi
requested changes
Feb 6, 2019
would you merge this for 2.7.2? |
|
Hi @djhi @fzaninotto Could you review/validate this PR? Thanks! |
|
Sorry @edy, as it is a new prop, can you please target the |
|
Done. Why isn't it possible to merge into master? All tests pass and the change is backward compatible too. |
|
As I said in previous comment, this adds a new prop, hence a new feature. If we do merge it, it will be on the |
Kmaschta
suggested changes
Mar 4, 2019
There was a problem hiding this comment.
Seems ok to me 👍
Just one thing: mind you document this new prop in the related doc?
https://github.com/marmelab/react-admin/blob/master/docs/Inputs.md#selectinput
|
also done |
Kmaschta
approved these changes
Mar 5, 2019
fzaninotto
approved these changes
Mar 8, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2234 introduced a breaking change for our application. This change adds an optional custom value which is used when allowEmpty is set.
Previously
nullwas set as an empty value, now you can set null again.