fix: delete-many keep selected items #2774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi and happy new year to you 😄
I'm opening this pull request as I encountered a bug.
When I'm selecting rows in
<List>
and using the default "bulk delete" button, the rows disappear but the "header" still show "X item selected", until I refresh the page.I investigated and found the issue.
It seems this code is not working as we are passing an
array
toindexOf
.I deleted it as this test seems useless in DELETE_MANY case.
Hope this is good ! 👌
Don't hesitate to tell me if I can do something more with this PR.