Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReferenceManyField doesn't rerender when the filter props changes #2753

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Fix ReferenceManyField doesn't rerender when the filter props changes #2753

merged 1 commit into from
Jan 11, 2019

Conversation

kandebr
Copy link
Contributor

@kandebr kandebr commented Jan 10, 2019 •
edited
Loading

Component ReferenceManyField takes filter prop but now it doesn't call fetching new data if filter changed. This PR can fix it.

@fzaninotto fzaninotto changed the title fetch new data when filter prop changed in ReferenceManyField Fix ReferenceManyField doesn't rerender when the filter props changes Jan 11, 2019
@fzaninotto
Copy link
Member

For a mysterious reason, the CI decided not to run on your previous commit. Would you mind re-pushing to trigger a build?

@kandebr kandebr closed this Jan 11, 2019
@kandebr kandebr reopened this Jan 11, 2019
@fzaninotto fzaninotto merged commit 869d073 into marmelab:master Jan 11, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 2.6.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kandebr @fzaninotto @djhi