Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix absence of 'modifiers' and 'disablePortal' for material-ui Popper #2677

Closed
wants to merge 2 commits into from
Closed

Fix absence of 'modifiers' and 'disablePortal' for material-ui Popper #2677

wants to merge 2 commits into from

Conversation

afilp
Copy link
Contributor

@afilp afilp commented Dec 18, 2018

Related issue: #2370

@afilp afilp changed the title Fix absence of 'modifiers' for material-ui Popper Fix absence of 'modifiers' and 'disablePortal' for material-ui Popper Dec 18, 2018
@djhi
Copy link
Collaborator

djhi commented Dec 18, 2018

Thanks but I think we shouldn't try to replicate props from the Popper component one by one. I'll have a PR for this soon, allowing to pass a suggestionContainerProps prop containing the props to pass to the Popper component. This is the favored pattern in MUI

@afilp
Copy link
Contributor Author

afilp commented Dec 18, 2018

Ok!

@fzaninotto
Copy link
Member

superseded by #2678

@fzaninotto fzaninotto closed this Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afilp @djhi @fzaninotto