Fix <AutoCompleteInput> should not display a "Create" option when the filter is empty
#10266
+246
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following #10228 (cause of revert commits) |
4 tasks
erwanMarmelab
commented
Oct 10, 2024
slax57
requested changes
Oct 11, 2024
Comment on lines
+472
to
+476
| export const CreateLabel = () => ( | ||
| <Wrapper> | ||
| <CreateLabelInput /> | ||
| </Wrapper> | ||
| ); |
There was a problem hiding this comment.
Found an issue in this story, where the Autocomplete displays the Create option for an item that already exists
EDIT: This issue seems to exist prior to this PR => Will be fixed in another PR
slax57
approved these changes
Oct 11, 2024
slax57
changed the title
<AutoCompleteInput> "Create" option for empty input<AutoCompleteInput> should not display a "Create" option when the filter is empty
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The “create option on-the-fly” UI of Autocomplete inputs is confusing. I can create an option with "" as value.
Fixes #10043
Solution
Create xxx->xxxHow To Test
ONLY=ra-ui-materialui make storybookhttp://localhost:9010/?path=/story/ra-ui-materialui-input-autocompleteinput--on-createAdditional Checks
masterfor a bugfix, ornextfor a feature- [ ] The PR includes one or several stories (if not possible, describe why)- [ ] The documentation is up to dateScreencasts
Before flash fix:
Capture vidéo du 2024-09-25 19-42-25.webm
After:
Capture vidéo du 2024-09-25 19-43-16.webm