Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pnpm error Module not found: Can't resolve '@mui/utils' #10264

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Oct 8, 2024

Problem

Fixes #10260

@mui/utils is used here https://github.com/marmelab/react-admin/blob/master/packages/ra-ui-materialui/src/theme/defaultTheme.ts#L2

But it is not explicitly declared as peerDependency here https://github.com/marmelab/react-admin/blob/master/packages/ra-ui-materialui/package.json#L54

Solution

Explicitly declare it as peerDependency

How To Test

Add a dependency on react-admin using pnpm 9.3.0

Additional Checks

  • The PR targets master for a bugfix, or next for a feature

Also, please make sure to read the contributing guidelines.

@slax57 slax57 added the RFR Ready For Review label Oct 8, 2024
@fzaninotto fzaninotto merged commit 78be308 into master Oct 8, 2024
14 checks passed
@fzaninotto fzaninotto deleted the add-mui-utils-to-peerDeps branch October 8, 2024 08:17
@fzaninotto fzaninotto added this to the 5.2.3 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ra-ui-materialui cannot resolve '@mui/utils'
2 participants