Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update <Search> doc for keyboardShortcutIcon, withKeyboardShortcut and isInAppBar #10254

Merged
merged 2 commits into from
Oct 3, 2024
Merged

[Doc] Update <Search> doc for keyboardShortcutIcon, withKeyboardShortcut and isInAppBar #10254

merged 2 commits into from
Oct 3, 2024

Conversation

erwanMarmelab
Copy link
Contributor

Problem

  • ra-search is just updated (with the creation of keyboardShortcutIcon and withKeyboardShortcut)
  • we don't document <Search isInAppBar>

Solution

  • Backport EE doc
  • Document <Search isInAppBar>

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The documentation is up to date

@erwanMarmelab erwanMarmelab added the RFR Ready For Review label Oct 2, 2024
djhi
djhi requested changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/Search.md Outdated Show resolved Hide resolved
@erwanMarmelab @djhi
remove useless comment
6515397 
Co-authored-by: Gildas Garcia <[email protected]>
@fzaninotto fzaninotto merged commit 0538e79 into master Oct 3, 2024
14 checks passed
@fzaninotto fzaninotto deleted the doc/search/keyboardshortcut branch October 3, 2024 08:52
@fzaninotto fzaninotto added this to the 5.2.3 milestone Oct 3, 2024
@FelipeX30 FelipeX30 mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi requested changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@erwanMarmelab @fzaninotto @djhi