Fix input validation and dirty state after re-enabling disabled fields

[michel-paiva]

Problem

• Disabled and re-enabled fields did not update their dirty state, causing validation to run after they have been re-enabled.

Related issues:
Closes #10156
Closes #9870

Solution

• This fix addresses the issue remove the workaround and making sure that a boolean value is passed to react-hook-form controller.

How To Test

• Verify that input fields with validation are correctly marked as dirty and trigger validation when they are re-enabled after being disabled.

[slax57]

Thank you, Boss. 🫡

[slax57]

It looks like one of the unit tests is failing, and this seems to be consequent to the react-hook-form version upgrade. This doesn't seem to be related to the code changed by this PR.
I'm currently investigating it...

[fzaninotto]

IMHO, this PR should be against the next branch as it upgrades a dependency to a minor version. There is a possibility that it breaks existing apps, which would be unexpected in a minor and even more in a bugfix release.

[slax57]

Okay, I managed to track down the issue, and filed a new issue on react-hook-form's repo: https://github.com/react-hook-form/react-hook-form/issues/12217

Depending on their answer, we may need to apply the workaround I mentioned to the useFormGroup.ts file.

Let's wait for their reply before taking actions.

[michel-paiva]

@slax57 seems like they tried to optimize renders by only setting isValidating for inputs that has async validation
https://github.com/react-hook-form/react-hook-form/pull/12192/files

[slax57]

@michel-paiva Okay, so this will probably not get fixed on their side.
That's why we opened #10168 to fix this issue on our side on master.

Now, can you please rebase your branch and PR to target the next branch?
You may also need to cherry-pick the fix I made to have your PR pass the CI checks.

Thank you.

[michel-paiva]

@slax57 done as you said, let's see!