Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the filter inputs full width by default on low screen resolution (mobile) #8795

Closed
soullivaneuh opened this issue Apr 3, 2023 · 4 comments · Fixed by #9169
Closed
Assignees

Comments

@soullivaneuh
Copy link
Contributor

It make more sense to me to have all the input taking a full width when we are on mobile view.

So instead of this being the default:

Before

Screen Shot 2023-04-03 at 21 00 22

I suggest to have this:

After

Screen Shot 2023-04-03 at 21 04 26

This is what I am willing to on my project. I may work on that but I would like to be sure about the idea first.

Thanks!

@fzaninotto
Copy link
Member

On Mobile, I agree with you - but on Mobile only.

@soullivaneuh
Copy link
Contributor Author

soullivaneuh commented Apr 3, 2023

Of course, we are on the same page here!

By the way, for the demo, I just added fullWidth on the configured filter of the OrderList and InvoiceList but it did not work. I had to hack with the debugger to achieve my demo screenshot.

However, the same method on my project which has the latest release works like a charm.

Is there any difference I should take care of?

@soullivaneuh
Copy link
Contributor Author

I also have an another wondering: Where should we apply this rule? Directly on the inputs scope, impacting both the filters and the form displays, or only gather to the filters?

The first option looks seducing to me.

@fzaninotto
Copy link
Member

Fixed by #9169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment